Skip to content

DIRECTOR: Ensure that GUI options are displayed for games that use them #6596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2025
Merged

DIRECTOR: Ensure that GUI options are displayed for games that use them #6596

merged 1 commit into from
May 5, 2025

Conversation

ccawley2011
Copy link
Member

No description provided.

@ccawley2011 ccawley2011 force-pushed the director-gui-options branch from 31de974 to 01cf24f Compare May 4, 2025 17:40
@bluegr
Copy link
Member

bluegr commented May 5, 2025

@ccawley2011 thanks!
This basically enhances the changes in commit 2f84260.

Can you provide a bit more context regarding the changes? What is the issue? Why is the gamma option working better with the changes in this PR?

@ccawley2011
Copy link
Member Author

Can you provide a bit more context regarding the changes? What is the issue? Why is the gamma option working better with the changes in this PR?

None of the detection entries had the relevant GAMEOPTION_* options specified in the GUIO string, so it would never show up in the options dialog. Doing it this way also guarantees it'll consistently show up for all Mac and Pippin games rather than just the ones that specify it in the detection entry, which is prone to error since not all entries use the macros.

@bluegr
Copy link
Member

bluegr commented May 5, 2025

Thanks! Makes sense now

Merging

@bluegr bluegr merged commit 8ce10e3 into scummvm:master May 5, 2025
8 checks passed
@ccawley2011 ccawley2011 deleted the director-gui-options branch May 5, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ccawley2011 @bluegr