Avoid type promotion in increment/decrement #27
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An operation on an integer array,
mat
, likewill promote the eltype of the result to
Int64
. A safer way of doing this so as to avoid needless promotion of types isbecause
true
theBool
value will always be promoted toeltype(mat)
.An in-place increment/decrement operation can safely be written as
because it is in-place
While making these changes I also changed the Project.toml file to allow later versions of
CategoricalArrays
and added[extras]
and[targets]
sections which can replacetest/Project.toml
. Finally I rewrote themake_testvalues
function intest/index.jl
to use a comprehension.