(chore): add docstring for InMemoryElem
#1641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ilan-gold
commented
Sep 3, 2024
•
ilan-gold
commented
- Towards 0.11 API #1634
- Tests added
- Release note added (or unnecessary)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1641 +/- ##
==========================================
- Coverage 86.81% 84.36% -2.46%
==========================================
Files 37 37
Lines 6008 6012 +4
==========================================
- Hits 5216 5072 -144
- Misses 792 940 +148
|
flying-sheep
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
Great, thanks! Clean descriptions.
Let’s talk about their names in #1634
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.