(chore): add Index type to __getitem__ for sparse dataset
#1648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1648 +/- ##
==========================================
- Coverage 86.87% 84.41% -2.47%
==========================================
Files 39 39
Lines 6033 6036 +3
==========================================
- Hits 5241 5095 -146
- Misses 792 941 +149
|
|
With “doc rendering fix”, you mean making it so “TypeVar” gets rendered more nicely or … ? |
YEs you had mentioned wanting it, and it maybe being a blocker? But I would merge as-is as well....so gonna request your review then...and if you want to block on it, ok |
flying-sheep
approved these changes
Sep 17, 2024
Co-authored-by: Philipp A. <flying-sheep@web.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting point. I think this should go in the next 0.11 release candidate (maybe along with your doc rendering fix @flying-sheep but doesn't have to). I would also be in favor of exporting this type since it is used elsewhere in quite important places.