Fix ArrayView and numpy subclassing #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivirshup
reviewed
Mar 9, 2020
anndata/_core/views.py
Outdated
Comment on lines
72
to
74
| if not isinstance(input_array, np.ndarray): | ||
| input_array = np.array(input_array) | ||
| arr = input_array.view(cls) |
There was a problem hiding this comment.
Suggested change
| if not isinstance(input_array, np.ndarray): | |
| input_array = np.array(input_array) | |
| arr = input_array.view(cls) | |
| arr = np.asanyarray(input_array).view(cls) |
Could this work instead? I think it should if your class is literally a np.ndarray subclass.
There was a problem hiding this comment.
Thanks for the suggestion! I've added a test and it works.
|
Any news on this? I wanted to fix the code-quality check (just for the test - either get overriding builtin when using |
|
Sorry, just been busy! I think this looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I have a
numpy.ndarraysubclass with some column annotations (alsondarrays), including aview-like object. Problem is that taking view of
adataobject first converts this tonp.ndarray,effectively removing my subclass (
arr = np.asarray(input_array)). This PR fixes this such that only non-arrays are converted to arrays, rest is left the same.