Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading in MERSCOPE sample data with squidpy.read.vizgen() doesn't work for every dataset? #686

Open
Laura-Waechter opened this issue May 9, 2023 · 9 comments

Comments

@Laura-Waechter
Copy link

Dear all,
I tried to follow this workflow (https://squidpy.readthedocs.io/en/stable/external_tutorials/tutorial_vizgen_mouse_liver.html) for the Human Liver cancer dataset (https://info.vizgen.com/ffpe-showcase) instead. But when using squidpy.read.vizgen(), the obsm and var from the AnnData object are only filled with NaN, despite the documents containing the same information as the mouse liver dataset. Did anyone have this problem before and knows how to solve it?
Thanks very much in advance!

@giovp
Copy link
Member

giovp commented May 9, 2023

hi @Laura-Waechter ,

could you try to install form main? pip install git+https://github.com/scverse/squidpy@main

let me know if it works,

@Laura-Waechter
Copy link
Author

Thanks for your fast reply @giovp . I now tried to install it the way you suggested, but the matrix is still empty...

@giovp
Copy link
Member

giovp commented May 9, 2023

can you try with #679 ?

@Laura-Waechter
Copy link
Author

I replaced the code of the function with this:
coords = coords.astype("str")
coords.index = coords.index.astype(adata.obs.index.dtype)
but that still doesn't help

@dfhannum
Copy link
Contributor

dfhannum commented Jun 5, 2023

This issue should be resolved now.

@giovp
Copy link
Member

giovp commented Jun 5, 2023

it is in main, thank you again @dfhannum . Am trying to cut release asap but encountering few hiccups, but should manage to do it this week.

@ghar1821
Copy link
Contributor

Hi guys, I'm encountering the same issue.

The read_vizgen function in master threw me the following error:

'DataFrameView' object has no attribute '_view_args'

from this line of code in read function (line 168):
adata.obs.drop(columns=["center_x", "center_y"], inplace=True)

Using the version in conda, I managed to run the function, but then the fov, volume, and center obs data is NaN.

And I'm using the Human Breast Cancer data that is publicly available on vizgen website.

@parkerstevenson
Copy link

parkerstevenson commented Apr 19, 2024

Hi all, I'm still encountering this issue using squidpy.read.vizgen(), the obs from the AnnData object are only filled with NaN after changing line 164 of the squidpy.read.vizgen() function from coords.set_index(coords.index.astype("str"), inplace=True) to coords.set_index(coords.index.astype(adata.obs.index.dtype), inplace=True)

@giovp
Copy link
Member

giovp commented Apr 22, 2024

hi both, I think the version in conda is not up to date yet, so please use the pip installable version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants