-
Notifications
You must be signed in to change notification settings - Fork 38
Configuration: implement application name, version and client id #554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuration: implement application name, version and client id #554
Conversation
Make driver report application name, version and client id to server on startup message.
56fddc5
to
1315a0e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two points:
If the CLIENT_ID
is not explicitly set, it should be randomly generated, right?
How can user later cross check the CLIENT_ID
with the information he obtains from the tables? Should it be logged somewhere once at the start of the session?
No, user get to generate it on they own.
It is their job, depends on deployment, on what they want, they may not use it at all. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's meant to be set by the user only then I think it looks ok.
Having it randomly generated if unset could preempt some back and forth in case of user issues, but not having it on by default also saves some bytes.
In PR scylladb#554 application API was implemented in the form of three additional Configuration attributes. This PR to have one Configuration attribute of `ApplicationInfo` interface. Default implementation of which will supply same three fields. `ApplicationInfo` interface is done in such a way that allows to inject any application information into startup message.
In PR scylladb#554 application API was implemented in the form of three additional Configuration attributes. This PR to have one Configuration attribute of `ApplicationInfo` interface. Default implementation of which will supply same three fields. `ApplicationInfo` interface is done in such a way that allows to inject any application information into startup message.
In PR #554 application API was implemented in the form of three additional Configuration attributes. This PR to have one Configuration attribute of `ApplicationInfo` interface. Default implementation of which will supply same three fields. `ApplicationInfo` interface is done in such a way that allows to inject any application information into startup message.
Make driver report application name, version and client id to server on startup message.
Fixes: #553
Tested: