Skip to content

Conversation

fruch
Copy link

@fruch fruch commented Mar 27, 2022

New Cluster property schema_metadata_page_size that controls
the page size of metadata queries, defaults to 1000.

Works only on CQL protocol v3/v4

Fixes: #139

@fruch fruch added test-build If this tag, do all build stages integration-tests If this tag, this PR won't run integration tests labels Mar 27, 2022
@fruch fruch self-assigned this Mar 27, 2022
@fruch fruch force-pushed the metadata_pagination branch from 307e38d to 7f00087 Compare March 27, 2022 07:49
New Cluster property `schema_metadata_page_size` that controls
the page size of metadata queries, defaults to 1000.

Works only on CQL protocol v3/v4

Fixes: scylladb#139
@fruch fruch force-pushed the metadata_pagination branch from 7f00087 to 2851121 Compare March 27, 2022 07:59
@fruch
Copy link
Author

fruch commented Mar 28, 2022

@ultrabug people gave a green light

@fruch fruch merged commit 6ad836c into scylladb:master Mar 28, 2022
fruch added a commit to fruch/python-driver that referenced this pull request Mar 29, 2022
Seems like that in scylladb#140, not all the queries coming out of
the metadata were covered (i.e. paginated), which was still
showing in `scylla_cql_unpaged_select_queries` counter.

all schema agreement queries are still unpaged:
```
SELECT peer, host_id, rpc_address, schema_version FROM system.peers
SELECT schema_version FROM system.local WHERE key='local'
```
fruch added a commit that referenced this pull request Mar 29, 2022
Seems like that in #140, not all the queries coming out of
the metadata were covered (i.e. paginated), which was still
showing in `scylla_cql_unpaged_select_queries` counter.

all schema agreement queries are still unpaged:
```
SELECT peer, host_id, rpc_address, schema_version FROM system.peers
SELECT schema_version FROM system.local WHERE key='local'
```
fruch added a commit to fruch/scylla-cluster-tests that referenced this pull request May 9, 2022
Cause of issues with creation connection while scylla is
loaded trying to use this version with this fix:
scylladb/python-driver#140
fruch added a commit to fruch/scylla-cluster-tests that referenced this pull request May 9, 2022
Cause of issues with creation connection while scylla is
loaded trying to use this version with this fix:
scylladb/python-driver#140
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests If this tag, this PR won't run integration tests test-build If this tag, do all build stages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metadata/Schema queries are not paginated
1 participant