Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(k8s-gke): skip flush and reshard nemesis due to the bug #5375

Merged

Conversation

vponomaryov
Copy link
Contributor

@vponomaryov vponomaryov commented Nov 1, 2022

Cause: scylladb/scylla-operator#1077

PR pre-checks (self review)

  • I followed KISS principle and best practices
  • I didn't leave commented-out/debugging code
  • I added the relevant backport labels
  • New configuration option are added and documented (in sdcm/sct_config.py)
  • I have added tests to cover my changes (Infrastructure only - under unit-test/ folder)
  • All new and existing unit tests passed (CI)
  • I have updated the Readme/doc folder accordingly (if needed)

@fruch fruch merged commit bfb8ebf into scylladb:master Nov 1, 2022
@fgelcer
Copy link
Contributor

fgelcer commented Nov 2, 2022

@vponomaryov , good practice is to give the bug a number, so we can track backwards, once the bug will be fixed

@fruch
Copy link
Contributor

fruch commented Nov 2, 2022

@vponomaryov , good practice is to give the bug a number, so we can track backwards, once the bug will be fixed

it's written in the code:
scylladb/scylla-operator#1077

@vponomaryov
Copy link
Contributor Author

@vponomaryov , good practice is to give the bug a number, so we can track backwards, once the bug will be fixed

As @fruch has already mentioned, the bug is referenced in the code change. So, good practice has been applied here from the start.

@fruch
Copy link
Contributor

fruch commented Nov 2, 2022

Having it also int the commit message and PR description could be even better, i.e. getting it linked to the bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/none Backport is not required Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants