-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tablets): remove tablets from experimental features #7512
Conversation
…erimental features tablets feature is not experimental anymore and is default to be enabled. tablets is dependent on consistent-topology-changes. refs: scylladb/scylladb#18898
9396700
to
f784c72
Compare
@@ -136,7 +136,6 @@ scylla_version: '' | |||
test_upgrade_from_installed_3_1_0: false | |||
target_upgrade_version: '' | |||
disable_raft: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still true? Do we disable raft by default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIUC this flag is not relevant anymore, unless still relevant to only 1 out of 2 raft features. @aleksbykov , @roydahan , can you please confirm?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably not.
@aleksbykov / @temichus ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This flag is only was used for rolling upgrade tests. Job with disabled raft uses additional yaml with relevant
if self.params.get("enable_tablets_on_upgrade"): | ||
with node.remote_scylla_yaml() as scylla_yml: | ||
current_experimental_features = scylla_yml.experimental_features | ||
current_experimental_features.remove("tablets") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we instead edit scylla.yaml to remove the newly introduced enable_tablets
config option?
(See scylladb/scylladb#18898)
@yarongilor your PR shouldn't touch raft experimntal - @aleksbykov / @temichus please organise it so whatever should be tested with "raft disabled" (consistent-topology) is correctly configured and remove all the unnecessary flags / configurations. @yarongilor your PR should flip the flag, now to support "disabling" tablets and have the duplicated jobs that are testing tablets with "disabled raft" - @aleksbykov & @temichus should be synced because some of these should be for 6.0 (so maybe they already working on it). |
Conclusions: @roydahan , @ShlomiBalalis , please advise - one thing we have to confirm is the tablets supported nemeses.
cc: @bhalevy |
refs: scylladb/scylladb#18898
i'm not sure this PR is needed and about its dependencies or anything else..
The PR also assumes there's no need of updating scylla yaml with:
"enable_tablets": "false"
Testing
PR pre-checks (self review)
backport
labelsReminders
sdcm/sct_config.py
)unit-test/
folder)