Skip to content

Conversation

jaredbriskman
Copy link

Here's our Interactive Programming project.


This change is Reviewable

Alexander Hoppe and others added 30 commits March 2, 2016 21:45
…ing into dev

Getting pseudo-synth wav playing code
Merge branch 'dev' of github.com:jaredbriskman/InteractiveProgramming into dev
Merge branch 'dev' of github.com:jaredbriskman/InteractiveProgramming into dev
@LucyWilcox
Copy link

Review status: 0 of 52 files reviewed at latest revision, 9 unresolved discussions.


entrytest.py, line 6 [r1] (raw file):
You should rename this something that's not entrytest if you are actually using it in your code and add a bit more documentation.


KeyListener.py, line 1 [r1] (raw file):
This all looks good!


synthesis.py, line 40 [r1] (raw file):
delete old comments that you're not using before submitting


synthesis.py, line 104 [r1] (raw file):
d, a, b, and c are not good names.


synthesis.py, line 124 [r1] (raw file):
Did you mean to have a print here?


synthesis.py, line 141 [r1] (raw file):
If exit isn't being used, delete it.


synthesis.py, line 162 [r1] (raw file):
Overall you could used a few more comments through out your code explaining what you are doing.


timingtest.py, line 1 [r1] (raw file):
Remove test files like this before you submit projects.


tkSimpleDialog.py, line 1 [r1] (raw file):
Might want to comment on how you are using this file


Comments from the review on Reviewable.io

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants