Skip to content

Conversation

poosomooso
Copy link

No description provided.

@kailevy
Copy link

kailevy commented Apr 1, 2016

Reviewed 15 of 15 files at r1.
Review status: all files reviewed at latest revision, 4 unresolved discussions.


Display.py, line 65 [r1] (raw file):
Lots of magic numbers around here.. documentation would be very helpful


Display.py, line 252 [r1] (raw file):
This class and its methods is only used once.. couldn't we have a larger controller class (combined with the input_menu) with an 'initial_menu' function or something along those lines?


ProjectProposal.txt, line 4 [r1] (raw file):
It appears you pivoted completely to do chart-making instead... something you should discuss in your reflection.


pycache/Display.cpython-35.pyc, line 0 [r1] (raw file):
Probably don't want to push this, use a .gitignore to ignore temporary files


Comments from the review on Reviewable.io

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants