Skip to content

Conversation

audreywl
Copy link

Just in time! Looking forward to the demo!

audreywl and others added 30 commits February 29, 2016 16:25
…and created a file to pickle values for an input song
…a song, but thinking we should probably incorporate as controller in MP4 instead.
…centuated and having the character not run off the screen
@kailevy
Copy link

kailevy commented Apr 5, 2016

Reviewed 10 of 10 files at r1.
Review status: all files reviewed at latest revision, 6 unresolved discussions.


load_song_values.pyc, line 0 [r1] (raw file):
Exclude these temporary files with your .gitignore


MP4.py, line 1 [r1] (raw file):
Documentation about dependencies and startup instructions would be very useful, and should go in your README (which you didn't modify so I can't comment on it)


MP4.py, line 35 [r1] (raw file):
I don't recommend doing any scripting in between functions, instead have them in your main()


MP4.py, line 123 [r1] (raw file):
I noticed a little bugginess with my character floating and jumping around, which I assume is from collision detection. Are the break statements really necessary?


MP4.py, line 217 [r1] (raw file):
Try to avoid magic numbers like these


MP4.py, line 263 [r1] (raw file):
This command completely pauses execution, which can have unexpected results. I would instead recommend keeping track of time with pygames get_ticks, and simply allow the model to change state when some amount of time has passed.


Comments from Reviewable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants