Skip to content

Conversation

diehlc1
Copy link

@diehlc1 diehlc1 commented Mar 10, 2016

Cecilia Diehl and Celina Bekins


This change is Reviewable

@LucyWilcox
Copy link

Review status: 0 of 641 files reviewed at latest revision, 11 unresolved discussions.


FinalMap.py, line 27 [r1] (raw file):
a isn't the best variable name here


FinalMap.py, line 69 [r1] (raw file):
What if you pre-processed the data and put into some form that could be accessed easily. Then you wouldn't need to reload and process all the data every single time you move the slider. This is why you're program is small. Also, then you could have pushed the code to process this in another file.

You could do something where you put data from all states into one file per each slider position, then you just determine the position and read one file for example.

Also you realized you pushed over 600 files. Anything to prevent that would have been really nice.


README.md, line 2 [r1] (raw file):
You've got to tell me what the needed libraries are.


stateDataCompile.py, line 2 [r1] (raw file):
do you use this? how?


stateDataCompilemore.py, line 2 [r1] (raw file):
do you use this? how?


testing.py, line 9 [r1] (raw file):
And another time, what is it and why? If you need help removing files from your repo let me know.


TestingSlider.py, line 9 [r1] (raw file):
Again, what is this? Why is it here? Are you using it?


TestMap.py, line 5 [r1] (raw file):
It seems like you're not using this in your final submission. What is it? Why is it here?


us_map.py, line 6 [r1] (raw file):
Did you guys change this at all? If so say how.


USmap, line 0 [r1] (raw file):
Why did you push an empty file. Having pushing 600+ files many of which aren't necessary isn't good.


USmap.py, line 9 [r1] (raw file):
???? why is this file here?


Comments from the review on Reviewable.io

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants