Skip to content

Conversation

lzuehsow
Copy link

This change is Reviewable

abuchele and others added 26 commits March 3, 2016 17:33
object movement tracking original base (green circle)
Fixed counter, added game initialization and event for movement of green object that's SUPPOSED to move the mouse, but wasn't able to get it working. The event won't trigger, can't figure out why!
GOT IT WORKING!
LITERALLY CONTROLS MOUSE MOTION BASED ON THE MOVEMENT OF A GREEN THING
HOLLA
…ler class organization system. Camera releases.
most recent, trying to sort out everything. it was working for a bit but it stopped, not sure why but i'll sort it out!
fixed events, mouse reacts. Added calibration feature (make time longer though). Added selection feature based on increase in radius. Ball isn't showing up.
final version!
@lzuehsow lzuehsow closed this Apr 18, 2016
@lzuehsow lzuehsow reopened this Apr 18, 2016
@kailevy
Copy link

kailevy commented May 5, 2016

Reviewed 1 of 2 files at r1, 2 of 2 files at r2, 1 of 1 files at r4, 1 of 1 files at r5, 1 of 1 files at r6, 5 of 5 files at r7, 1 of 1 files at r8, 13 of 13 files at r10.
Review status: all files reviewed at latest revision, 7 unresolved discussions.


interactiveprogramming.py, line 1 [r10] (raw file):
Cool stuff, I like what you've done! However, when I run your program, it runs smoothly for ~10 seconds and then throws an error:

HIGHGUI ERROR: V4L/V4L2: VIDIOC_S_CROP

interactiveprogramming.py, line 100 [r10] (raw file):
I would try to avoid magic numbers like these.. why 300?


interactiveprogramming.py, line 123 [r10] (raw file):
What's this for? It seems unnecessary


interactiveprogramming.py, line 137 [r10] (raw file):
Setting a variable to True doesn't make this anything different from a while True loop, which are generally good to avoid-- although I can see how it is useful in your case


interactiveprogramming.py, line 269 [r10] (raw file):
I would recommend encapsulating the bulk of your program into other functions, rather than having it written inline in the main


interactiveprogramming1.py, line 1 [r10] (raw file):
What is this file for? It doesn't seem to work.


object_movement.py, line 1 [r10] (raw file):
These all seem to be unused and unworking... I highly recommend using git for its intended purpose, which would eliminate the need to copy code from file to file as you write it.


Comments from Reviewable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants