Skip to content

Conversation

beccagetto
Copy link

Sorry, I didn't realize both team members had to make a pull request for this assignment...


This change is Reviewable

@frantonlin
Copy link

It would have been good to remove extra test files before submitting (not a huge deal).


Reviewed 11 of 14 files at r1, 1 of 1 files at r2, 3 of 5 files at r3.
Review status: all files reviewed at latest revision, 3 unresolved discussions.


Fall_cupcake_theme.py, line 12 [r3] (raw file):
Constants (variables that aren't modified) are generally defined with all uppercase names.


Fall_cupcake_theme.py, line 70 [r3] (raw file):
Good on having comments for everything. One note is that if you'd like to have even better documentation, you could put comments for what all of the parameters are and what the output is expected to be.


Fall_cupcake_theme.py, line 266 [r3] (raw file):
Good direct separation of MVC.


Comments from Reviewable

@frantonlin
Copy link

Review status: all files reviewed at latest revision, 4 unresolved discussions.


ProjectRefelction.pdf, line 0 [r3] (raw file):
Solid, very detailed project writeup!


Comments from Reviewable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants