ui_system: modified system prefs page #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,379 +1,399 @@ | |||
| <?php global $_config, $languageManager, $_config_defaults, $stripslashes;?> | |||
| }).appendTo(toggleSwitch); | ||
|
|
||
| toggleSwitch.click(function () { | ||
| var anchor = inputs[0].checked ? inputs[1] : inputs[0]; |
There was a problem hiding this comment.
You are using inputs[0] and inputs[1] all over the code. First of all, it makes sense to use a separate variable for those cases. Secondly, you want to give a meaningful names for those variables because it is very hard to understand for a developer what those inputs[0] and inputs[1] represent. And lastly, in the case (if for any reason) your
inputs = toggleSwitch.find("input") returns and empty jQuery array you will have JavaScript exceptions for inputs[0] and inputs[1]
…by using a different compression tool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.