fix overflow bug in the dot product #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great tutorial! Thanks for the work. |
|
BTW I did not have time to update numpile.py, but it should be easily done. |
|
It's hard to read the git diff for the changes to the type inference from the IPython notebook dump. Can you make the change in numpile.py? |
|
done! you should see it in the PR. |
|
LGTM, I'll just pull it and make sure everything builds fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dot example gives wrong result due to an overflow in int32 accumulator. This PR fixes it by working with int64 arrays instead. To make this change feasible the following changes were implemented:
visit_Loopmethod ofTypeInferto use consistently int32 on start, increment and end condition,allocawas change to keyword argument for compatiblity with the new llvmpy