Fixed Numpy boolean array indexing issue for 2dim arrays. #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Numpy requires the use of masking for all boolean array indexing on non 1 or 0-d arrays. Therefore the following line breaks all estimators when using the conventional Nx1 sklearn data format for regression, which this library also requires. pred[ind] = p This commit uses a mask to fix this.
|
I'll close this PR as the changes have been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Numpy requires the use of masking for all boolean array indexing on non 1 or 0-d arrays. Therefore the following line breaks all estimators when using the conventional Nx1 sklearn data format for regression, which this library also requires.
pred[ind] = p
More details: https://stackoverflow.com/questions/60079094/python-error-numpy-boolean-array-indexing-assignment-requires-a-0-or-1-dimensi
This commit uses a mask to fix this.