Skip to content

feat(vue3) add composition api #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 2, 2020

Conversation

darrenjennings
Copy link
Contributor

This PR is for some composition api snippets. I made a call to prefix with v3 but open for bikeshedding. The autocomplete in vscode is good enough that typing vwatch would still show you the v3 results.

  • added v3 to all snippet prefix so that it's easier to filter e.g.:
    image
  • vbase- did not prefix with v3 because vbase is ingrained and so I figured it'd be helpful to give it some priority when opening a new file.

May-11-2020 16-09-25

@sdras
Copy link
Owner

sdras commented May 25, 2020

nice! thanks!

@sdras
Copy link
Owner

sdras commented May 25, 2020

Oh wait, this needs an addition to the readme as well- a key for all the snippets added

@darrenjennings
Copy link
Contributor Author

@sdras updated!

@darrenjennings
Copy link
Contributor Author

@sdras anything I can do to help get this merged in?

@sdras
Copy link
Owner

sdras commented Aug 2, 2020

Perfect, thank you! Merging and releasing now.

@sdras sdras merged commit 63a6480 into sdras:master Aug 2, 2020
@sdras
Copy link
Owner

sdras commented Aug 2, 2020

Released! 🎉 Thank you so much for this valuable contribution, it was on my list to add in.

@darrenjennings darrenjennings deleted the feat/composition-api branch August 2, 2020 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants