Don't count newline against commit subject length #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add example verifying that lines in the commit message are allowed to be the length of the limit plus a trailing newline character.
When comparing the commit subject against the specified limit, trailing newlines should not be considered part of a subject's character count.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes apply to the
Overcommit::Hooks::CommitMsg::TextWidthhook.When specifying a
max_subject_width, I expect to be able to type out a commit subject as long as the specified max width. However, because the hook counts the newline character, the hook fails.This pull request takes the behavior used for the commit body -- i.e., not counting a trailing newline against the total width -- and applies that to the commit subject as well.