Add working libraries #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #288 +/- ##
==========================================
- Coverage 87.25% 87.16% -0.09%
==========================================
Files 27 27
Lines 1702 1706 +4
==========================================
+ Hits 1485 1487 +2
- Misses 217 219 +2
Continue to review full report at Codecov.
|
fealho
commented
Nov 17, 2021
| @@ -111,7 +111,7 @@ def compare_1d(real, synth, columns=None, figsize=None): | |||
| fig = plt.figure(figsize=figsize) | |||
|
|
|||
| for idx, column in enumerate(columns): | |||
| position = prefix + str(idx + 1) | |||
| position = int(prefix + str(idx + 1)) | |||
There was a problem hiding this comment.
This change is needed to avoid the following error: https://github.com/sdv-dev/Copulas/runs/4223940873?check_suite_focus=true. This seems unrelated to my code changes, and due to an update in the API of matplotlib.
amontanez24
approved these changes
Nov 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #278 .
Initially, this PR will add the addons which the code already passes.
This is the base PR in which all other addons will be added (each one will be implemented in a different PR).