Add pep8-naming
#298
Merged
Add pep8-naming
#298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## issue-278-base #298 +/- ##
===============================================
Coverage 87.25% 87.25%
===============================================
Files 27 27
Lines 1702 1702
===============================================
Hits 1485 1485
Misses 217 217 Continue to review full report at Codecov.
|
fealho
commented
Nov 18, 2021
tasks.py
Outdated
| @@ -115,8 +115,9 @@ def tutorials(c): | |||
| @task | |||
| def lint(c): | |||
| check_dependencies(c) | |||
| c.run('flake8 copulas') | |||
| c.run('flake8 tests --ignore=D,SFS2') | |||
| c.run('flake8 copulas --ignore-names=X,U,V,W,A,B,T1,X_left_right,X_right_left,' \ | |||
There was a problem hiding this comment.
@csala Not sure what we want to do on this one. Lint complains that they start with capital letters, but we since they are matrices, they should be capitalized.
There was a problem hiding this comment.
As discussed on call, the ignores are fine, but we should move them to setup.cfg
fealho
requested review from
amontanez24 and
csala
and removed request for
a team
amontanez24
approved these changes
Nov 19, 2021
csala
reviewed
Nov 22, 2021
setup.cfg
Outdated
| @@ -34,7 +34,9 @@ universal = 1 | |||
| [flake8] | |||
| max-line-length = 99 | |||
| exclude = docs, .git, __pycache__, .ipynb_checkpoints | |||
| ignore = W503 | |||
| extend_ignore = W503, | |||
There was a problem hiding this comment.
In some other PRs this is called extend-ignore.
Also see this comment about the ignore vs extend-ignore
fealho
commented
Nov 23, 2021
setup.cfg
Outdated
| extend_ignore = W503, | ||
| N803, # argument name 'X' should be lowercase | ||
| N806, # variable 'X' in function should be lowercase | ||
| SFS3 # String literal formatting using f-string. |
There was a problem hiding this comment.
I'll fix the formatting the indentation here in the base PR, after this is merged.
csala
approved these changes
Nov 23, 2021
fealho
added a commit
that referenced
this pull request
Nov 24, 2021
* Add working libraries * Add addon * Remove pydocstyle * Fix unrelated error * Make double quotes into single (#289) * Add `flake8-eradicate` (#293) * Add addon * Remove paranthesis because the addon thinks they are code * Add addon * Remove paranthesis because the addon thinks they are code * Add `flake8-builtins` (#296) * Add addon * Update code according to addon * Add addon * Update code according to addon * Add `pandas-vet` (#299) * Add addon * Update code according to addon * Add addon * Update code according to addon * Add absolute import * Add sfs (#305) * Add `flake8-multiline-containers` (#290) * Not sure what to do about these * Add noqa's where necessary * Not sure what to do about these * Add noqa's where necessary * Address feedback * Add `flake8-expression-complexity` (#291) * Add addon * Change the complexity limit to 8 from 7 * Add addon * Change the complexity limit to 8 from 7 * Fix complexity * Rename + remove unnecessary argsort * Add `flake8-print` (#292) * Add addon * Address feedback * Add `flake8-comprehensions` (#295) * Add addon * Fix code according to addon * Add addon * Fix code according to addon * Fix errors * Fix set as literal * Address feedback * Add `pytest-style` (#297) * Add addon * Update code according to addon * Add addon * Update code according to addon * Fix errors * Delete pytest * Address feedback * Add `flake8-docstrings` (#301) * Add addon * Update code according to addon * Add addon * Update code according to addon * Update code according to pydocstyle * Fixes * Fix errors * Update docstrings * Fix typos * Add addon and ignore erros (#304) * Add `flake8-dlint` (#300) * Add addon * Ignore error * Add addon * Ignore error * Add `pep8-naming` (#298) * Add addon * Ignore all the variable names * Add addon * Ignore all the variable names * Move ignores to setup.cfg * Add `flake8-fixme` (#294) * Add addon * Remove fixme * Add addon * Remove fixme * Fix bug * Fix details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #278 , added
flake8-namingaddon and adapted our code to follow this style check.