Add flake8-expression-complexity
#291
Conversation
Codecov Report
@@ Coverage Diff @@
## issue-278-base #291 +/- ##
==================================================
- Coverage 87.25% 87.17% -0.08%
==================================================
Files 27 27
Lines 1702 1707 +5
==================================================
+ Hits 1485 1488 +3
- Misses 217 219 +2
Continue to review full report at Codecov.
|
tasks.py
Outdated
| @@ -115,8 +115,8 @@ def tutorials(c): | |||
| @task | |||
| def lint(c): | |||
| check_dependencies(c) | |||
| c.run('flake8 copulas') | |||
| c.run('flake8 tests --ignore=D,SFS2') | |||
| c.run('flake8 copulas --max-expression-complexity=8') | |||
There was a problem hiding this comment.
The standard limit is 7, but around 10 expressions have complexity of 7.5. Since it seemed silly to decrease the complexity of the expressions (they are just implementations of equations) I increased the cap.
There was a problem hiding this comment.
Is there a way to put this in a config instead of in the command?
There was a problem hiding this comment.
@fealho can you point at some of these expressions?
In general the complexity can be decreased by capturing some things in intermediate variables, so I suspect we would want to do that.
There was a problem hiding this comment.
Sure, I moved the limit back to 7 and I added the intermediate variables (you can check the specific examples in the code), I just think it doesn't necessarily improve code readability. I'm fine with it either way though.
fealho
requested review from
amontanez24 and
csala
and removed request for
a team
* Add working libraries * Add addon * Remove pydocstyle * Fix unrelated error * Make double quotes into single (#289) * Add `flake8-eradicate` (#293) * Add addon * Remove paranthesis because the addon thinks they are code * Add addon * Remove paranthesis because the addon thinks they are code * Add `flake8-builtins` (#296) * Add addon * Update code according to addon * Add addon * Update code according to addon * Add `pandas-vet` (#299) * Add addon * Update code according to addon * Add addon * Update code according to addon * Add absolute import * Add sfs (#305) * Add `flake8-multiline-containers` (#290) * Not sure what to do about these * Add noqa's where necessary * Not sure what to do about these * Add noqa's where necessary * Address feedback * Add `flake8-expression-complexity` (#291) * Add addon * Change the complexity limit to 8 from 7 * Add addon * Change the complexity limit to 8 from 7 * Fix complexity * Rename + remove unnecessary argsort * Add `flake8-print` (#292) * Add addon * Address feedback * Add `flake8-comprehensions` (#295) * Add addon * Fix code according to addon * Add addon * Fix code according to addon * Fix errors * Fix set as literal * Address feedback * Add `pytest-style` (#297) * Add addon * Update code according to addon * Add addon * Update code according to addon * Fix errors * Delete pytest * Address feedback * Add `flake8-docstrings` (#301) * Add addon * Update code according to addon * Add addon * Update code according to addon * Update code according to pydocstyle * Fixes * Fix errors * Update docstrings * Fix typos * Add addon and ignore erros (#304) * Add `flake8-dlint` (#300) * Add addon * Ignore error * Add addon * Ignore error * Add `pep8-naming` (#298) * Add addon * Ignore all the variable names * Add addon * Ignore all the variable names * Move ignores to setup.cfg * Add `flake8-fixme` (#294) * Add addon * Remove fixme * Add addon * Remove fixme * Fix bug * Fix details
As part of #80, added
flake8-expression-complexityaddon and adapted our code to follow this style check.