Add pytest-style
#297
Merged
Add pytest-style
#297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## issue-278-base #297 +/- ##
===============================================
Coverage 87.25% 87.25%
===============================================
Files 27 27
Lines 1702 1702
===============================================
Hits 1485 1485
Misses 217 217 Continue to review full report at Codecov.
|
csala
reviewed
Nov 19, 2021
tests/unit/bivariate/test_clayton.py
Outdated
| @@ -22,8 +22,8 @@ def setUp(self): | |||
| def test_fit(self): | |||
| """On fit, theta and tau attributes are set.""" | |||
| self.copula.fit(self.X) | |||
| self.assertAlmostEqual(self.copula.tau, 0.7877, places=3) | |||
| self.assertAlmostEqual(self.copula.theta, 7.4218, places=3) | |||
| assert self.copula.tau, 0.7877 | |||
There was a problem hiding this comment.
This change does not seem correct.
Here we are saying assert self.copula.tau and if it fails, give 0.7877 as the message.
I think we should rather be using pytest.approx
There was a problem hiding this comment.
Oh, I forgot to write this test (that was the placeholder I left there), great catch! I'll use the same syntax I'm using in the other tests, for consistency (since you mentioned it's fine in the comment below).
csala
reviewed
Nov 19, 2021
| @@ -23,8 +23,8 @@ def setUp(self): | |||
| def test_fit(self): | |||
| """On fit, theta and tau attributes are set.""" | |||
| self.copula.fit(self.X) | |||
| self.assertAlmostEqual(self.copula.tau, 0.7877, places=3) | |||
| self.assertAlmostEqual(self.copula.theta, 17.0227, places=3) | |||
| assert 0.7877 <= self.copula.tau < 0.7878 | |||
There was a problem hiding this comment.
All these could be done using pytest.approx, but this approach is good too!
csala
approved these changes
Nov 22, 2021
fealho
added a commit
that referenced
this pull request
Nov 24, 2021
* Add working libraries * Add addon * Remove pydocstyle * Fix unrelated error * Make double quotes into single (#289) * Add `flake8-eradicate` (#293) * Add addon * Remove paranthesis because the addon thinks they are code * Add addon * Remove paranthesis because the addon thinks they are code * Add `flake8-builtins` (#296) * Add addon * Update code according to addon * Add addon * Update code according to addon * Add `pandas-vet` (#299) * Add addon * Update code according to addon * Add addon * Update code according to addon * Add absolute import * Add sfs (#305) * Add `flake8-multiline-containers` (#290) * Not sure what to do about these * Add noqa's where necessary * Not sure what to do about these * Add noqa's where necessary * Address feedback * Add `flake8-expression-complexity` (#291) * Add addon * Change the complexity limit to 8 from 7 * Add addon * Change the complexity limit to 8 from 7 * Fix complexity * Rename + remove unnecessary argsort * Add `flake8-print` (#292) * Add addon * Address feedback * Add `flake8-comprehensions` (#295) * Add addon * Fix code according to addon * Add addon * Fix code according to addon * Fix errors * Fix set as literal * Address feedback * Add `pytest-style` (#297) * Add addon * Update code according to addon * Add addon * Update code according to addon * Fix errors * Delete pytest * Address feedback * Add `flake8-docstrings` (#301) * Add addon * Update code according to addon * Add addon * Update code according to addon * Update code according to pydocstyle * Fixes * Fix errors * Update docstrings * Fix typos * Add addon and ignore erros (#304) * Add `flake8-dlint` (#300) * Add addon * Ignore error * Add addon * Ignore error * Add `pep8-naming` (#298) * Add addon * Ignore all the variable names * Add addon * Ignore all the variable names * Move ignores to setup.cfg * Add `flake8-fixme` (#294) * Add addon * Remove fixme * Add addon * Remove fixme * Fix bug * Fix details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #278, added
pytest-styleaddon and adapted our code to follow this style check.