Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flake8-dlint #300

Merged
merged 6 commits into from
Nov 23, 2021
Merged

Add flake8-dlint #300

merged 6 commits into from
Nov 23, 2021

Conversation

fealho
Copy link
Member

@fealho fealho commented Nov 10, 2021

As part of #278, added flake8-dlint addon and adapted our code to follow this style check.

@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2021

Codecov Report

Merging #300 (43025c2) into issue-278-base (88909fe) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           issue-278-base     #300   +/-   ##
===============================================
  Coverage           87.25%   87.25%           
===============================================
  Files                  27       27           
  Lines                1702     1702           
===============================================
  Hits                 1485     1485           
  Misses                217      217           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88909fe...43025c2. Read the comment docs.

@fealho fealho changed the base branch from issue-278-base to master November 17, 2021 15:56
@fealho fealho changed the base branch from master to issue-278-base November 17, 2021 15:56
@fealho fealho marked this pull request as ready for review November 17, 2021 15:57
@fealho fealho requested a review from a team as a code owner November 17, 2021 15:57
@fealho fealho requested review from katxiao and removed request for a team November 17, 2021 15:57
Copy link
Contributor

@katxiao katxiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

setup.cfg Outdated Show resolved Hide resolved
@fealho fealho merged commit d16f540 into issue-278-base Nov 23, 2021
@fealho fealho deleted the issue-278-dlint branch November 23, 2021 02:07
fealho added a commit that referenced this pull request Nov 24, 2021
* Add working libraries

* Add addon

* Remove pydocstyle

* Fix unrelated error

* Make double quotes into single (#289)

* Add `flake8-eradicate` (#293)

* Add addon

* Remove paranthesis because the addon thinks they are code

* Add addon

* Remove paranthesis because the addon thinks they are code

* Add `flake8-builtins` (#296)

* Add addon

* Update code according to addon

* Add addon

* Update code according to addon

* Add `pandas-vet` (#299)

* Add addon

* Update code according to addon

* Add addon

* Update code according to addon

* Add absolute import

* Add sfs (#305)

* Add `flake8-multiline-containers` (#290)

* Not sure what to do about these

* Add noqa's where necessary

* Not sure what to do about these

* Add noqa's where necessary

* Address feedback

* Add `flake8-expression-complexity` (#291)

* Add addon

* Change the complexity limit to 8 from 7

* Add addon

* Change the complexity limit to 8 from 7

* Fix complexity

* Rename + remove unnecessary argsort

* Add `flake8-print` (#292)

* Add addon

* Address feedback

* Add `flake8-comprehensions` (#295)

* Add addon

* Fix code according to addon

* Add addon

* Fix code according to addon

* Fix errors

* Fix set as literal

* Address feedback

* Add `pytest-style` (#297)

* Add addon

* Update code according to addon

* Add addon

* Update code according to addon

* Fix errors

* Delete pytest

* Address feedback

* Add `flake8-docstrings` (#301)

* Add addon

* Update code according to addon

* Add addon

* Update code according to addon

* Update code according to pydocstyle

* Fixes

* Fix errors

* Update docstrings

* Fix typos

* Add addon and ignore erros (#304)

* Add `flake8-dlint` (#300)

* Add addon

* Ignore error

* Add addon

* Ignore error

* Add `pep8-naming` (#298)

* Add addon

* Ignore all the variable names

* Add addon

* Ignore all the variable names

* Move ignores to setup.cfg

* Add `flake8-fixme` (#294)

* Add addon

* Remove fixme

* Add addon

* Remove fixme

* Fix bug

* Fix details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants