Skip to content

Wrong default values for the classifier parameter of the BinaryClassifierPrecisionEfficacy #734

@R-Palazzo

Description

@R-Palazzo

Environment Details

  • SDMetrics version: 0.19.0

Error Description

The current default value of the classifier parameter of the BinaryClassifierPrecisionEfficacy is 'xgboost' while it should be 'XGBoost' (from the docs and the input validation). We should update the value to be 'XGBoost'

Steps to reproduce

If no values is given to classifier, the metric crahes with this error:

ValueError: Currently only `XGBoost` is supported as classifier.
score_breakdown = BinaryClassifierPrecisionEfficacy.compute_breakdown(
    real_training_data=real_training,
    synthetic_data=synthetic_data,
    real_validation_data=real_validation,
    metadata=metadata,
    prediction_column_name='high_spec',
    minority_class_label='Science',
    fixed_recall_value=0.8,
)

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions