Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions sdmetrics/column_pairs/statistical/inter_row_msas.py
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,14 @@ def _validate_inputs(real_data, synthetic_data, n_rows_diff, apply_log):
@staticmethod
def _apply_log(real_values, synthetic_values, apply_log):
if apply_log:
if pd.api.types.is_datetime64_any_dtype(
real_values
) or pd.api.types.is_datetime64_any_dtype(synthetic_values):
raise TypeError(
'Cannot compute log for datetime columns. '
"Please set 'apply_log' to False to use this metric."
)

num_invalid = sum(x <= 0 for x in pd.concat((real_values, synthetic_values)))
if num_invalid:
warnings.warn(
Expand Down
22 changes: 22 additions & 0 deletions tests/unit/column_pairs/statistical/test_inter_row_msas.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
from datetime import datetime

import pandas as pd
import pytest

Expand Down Expand Up @@ -96,6 +98,26 @@ def test_compute_with_log_warning(self):
assert str(warning_info[0].message) == expected_message
assert score == 0

def test_compute_with_log_datetime(self):
"""Test it crashes for logs of datetime values."""
# Setup
real_keys = pd.Series(['id1', 'id1'])
real_values = pd.Series([datetime(2020, 10, 1), datetime(2020, 10, 1)])
synthetic_keys = pd.Series(['id2', 'id2'])
synthetic_values = pd.Series([datetime(2020, 10, 1), datetime(2020, 10, 1)])

# Run and Assert
err_msg = (
'Cannot compute log for datetime columns. '
"Please set 'apply_log' to False to use this metric."
)
with pytest.raises(TypeError, match=err_msg):
InterRowMSAS.compute(
real_data=(real_keys, real_values),
synthetic_data=(synthetic_keys, synthetic_values),
apply_log=True,
)

def test_compute_different_n_rows_diff(self):
"""Test it with different n_rows_diff."""
# Setup
Expand Down
Loading