Add DisclosureProtectionEstimate metric
#686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #686 +/- ##
==========================================
+ Coverage 94.29% 94.39% +0.10%
==========================================
Files 106 106
Lines 4031 4103 +72
==========================================
+ Hits 3801 3873 +72
Misses 230 230
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
frances-h
force-pushed
the
issue-675-DisclosureProtection
branch
from
fef7932 to
6d21816
Compare
frances-h
force-pushed
the
issue-676-DisclosureProtectionEstimate
branch
2 times, most recently
from
42cd6d3 to
5a624e6
Compare
frances-h
force-pushed
the
issue-675-DisclosureProtection
branch
from
7a067fd to
0918f8c
Compare
frances-h
force-pushed
the
issue-676-DisclosureProtectionEstimate
branch
from
5a624e6 to
f4a47e2
Compare
frances-h
requested review from
amontanez24 and
pvk-developer
and removed request for
a team
pvk-developer
approved these changes
Dec 9, 2024
amontanez24
reviewed
Dec 9, 2024
Comment on lines
+354
to
+355
| real_data_samp = real_data.sample(min(num_rows_subsample, len(real_data))) | ||
| synth_data_samp = synthetic_data.sample(min(num_rows_subsample, len(synthetic_data))) |
There was a problem hiding this comment.
what happens if the length of these two arrays differ because one has less than the number of rows to subsample and the other doesn't? Does that matter?
There was a problem hiding this comment.
For the underlying CAG metric it doesn't matter, since the metric doesn't need the real/synthetic data to be equally sized.
frances-h
force-pushed
the
issue-676-DisclosureProtectionEstimate
branch
from
f4a47e2 to
285cd08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #676
CU-86b2ypdtp