Skip to content

Conversation

R-Palazzo
Copy link
Contributor

CU-86b3v4dm3
Resolve #716

@R-Palazzo R-Palazzo self-assigned this Feb 11, 2025
@R-Palazzo R-Palazzo requested a review from a team as a code owner February 11, 2025 15:40
@sdv-team
Copy link
Contributor

@R-Palazzo R-Palazzo removed the request for review from a team February 11, 2025 15:40
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.13%. Comparing base (b417627) to head (bdceea9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #722      +/-   ##
==========================================
+ Coverage   95.08%   95.13%   +0.05%     
==========================================
  Files         111      111              
  Lines        4290     4299       +9     
==========================================
+ Hits         4079     4090      +11     
+ Misses        211      209       -2     
Flag Coverage Δ
integration 79.20% <93.33%> (+0.04%) ⬆️
unit 82.53% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@fealho fealho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@R-Palazzo R-Palazzo force-pushed the issue-716-num_rows_subsample branch from 95f63a8 to 1699a7c Compare February 12, 2025 10:21
@R-Palazzo R-Palazzo merged commit 0602ab6 into main Feb 12, 2025
47 checks passed
@R-Palazzo R-Palazzo deleted the issue-716-num_rows_subsample branch February 12, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow subsampling when computing the ContingencySimilarity metric
4 participants