Speed up calculation of the QualityReport #723
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #723 +/- ##
=======================================
Coverage 95.09% 95.09%
=======================================
Files 111 111
Lines 4299 4303 +4
=======================================
+ Hits 4088 4092 +4
Misses 211 211
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
frances-h
reviewed
Feb 12, 2025
sdmetrics/reports/single_table/_properties/column_pair_trends.py
Outdated
Show resolved
Hide resolved
R-Palazzo
force-pushed
the
issue-718-speed-up-quality-reports
branch
from
e69e080 to
8990f35
Compare
frances-h
reviewed
Feb 12, 2025
amontanez24
reviewed
Feb 12, 2025
Comment on lines
189
to
195
| metric_parameters = {} | ||
| if (metric == ContingencySimilarity) and ( | ||
| max(len(data_real), len(data_synthetic)) > DEFAULT_NUM_ROWS_SUBSAMPLE | ||
| ): | ||
| metric_parameters['num_rows_subsample'] = DEFAULT_NUM_ROWS_SUBSAMPLE | ||
|
|
||
| return data_real, data_synthetic, metric, metric_parameters |
There was a problem hiding this comment.
why not just do this in the calling method (_generate_details) instead of adding another return value to this method?
frances-h
approved these changes
Feb 13, 2025
amontanez24
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CU-86b3w6r0k
Resolve #718