Skip to content

Conversation

R-Palazzo
Copy link
Contributor

@R-Palazzo R-Palazzo commented Feb 21, 2025

CU-86b3zyra8
Resolve #727

This PR contains 3 main contributions:

Since news metrics include metadata as a parameter, it's beneficial to always refer to what's defined in _utils_metadata.py to ensure consistency.

@R-Palazzo R-Palazzo self-assigned this Feb 21, 2025
@R-Palazzo R-Palazzo requested a review from a team as a code owner February 21, 2025 16:38
@sdv-team
Copy link
Contributor

@R-Palazzo R-Palazzo removed the request for review from a team February 21, 2025 16:38
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

Attention: Patch coverage is 99.09910% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.29%. Comparing base (2dc391a) to head (4a20f7e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
sdmetrics/_utils_metadata.py 98.79% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #729      +/-   ##
==========================================
+ Coverage   95.09%   95.29%   +0.19%     
==========================================
  Files         111      112       +1     
  Lines        4305     4378      +73     
==========================================
+ Hits         4094     4172      +78     
+ Misses        211      206       -5     
Flag Coverage Δ
integration 79.57% <88.28%> (+0.36%) ⬆️
unit 82.98% <98.19%> (+0.42%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@R-Palazzo R-Palazzo force-pushed the issue-727-metadata-metrics branch from 3651a13 to 6793bf9 Compare February 24, 2025 11:12
Copy link
Contributor

@frances-h frances-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for centralizing this!

@R-Palazzo R-Palazzo merged commit 00f63b6 into main Feb 24, 2025
55 checks passed
@R-Palazzo R-Palazzo deleted the issue-727-metadata-metrics branch February 24, 2025 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use metadata to validate inputs to BinaryClassifierEfficacy precision and recall metrics
4 participants