Upgrade pomegranate dependency to Python 3.13
#736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #736 +/- ##
==========================================
+ Coverage 95.29% 95.43% +0.13%
==========================================
Files 112 112
Lines 4378 4379 +1
==========================================
+ Hits 4172 4179 +7
+ Misses 206 200 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
R-Palazzo
commented
Feb 28, 2025
Comment on lines
+50
to
+54
| # Run | ||
| result = metric.compute(real_data, synthetic_data, metadata) | ||
|
|
||
| # Assert | ||
| assert np.isclose(result, 0.1111111044883728, atol=1e-5) |
There was a problem hiding this comment.
Those tests ensure the metric computation remains consistent while upgrading pomegranate.
rwedge
reviewed
Feb 28, 2025
rwedge
reviewed
Feb 28, 2025
rwedge
reviewed
Feb 28, 2025
rwedge
reviewed
Feb 28, 2025
amontanez24
reviewed
Mar 4, 2025
rwedge
approved these changes
Mar 13, 2025
amontanez24
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CU-86b3vfzp4
Resolve #717