Skip to content

Wrong default values for the classifier parameter of the BinaryClassifierPrecisionEfficacy #749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 19, 2025
Merged

Wrong default values for the classifier parameter of the BinaryClassifierPrecisionEfficacy #749

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3029569
fix
R-Palazzo Mar 18, 2025
97f90ac
update tests
R-Palazzo Mar 18, 2025
843e74f
integration tests + pin xgboost
R-Palazzo Mar 18, 2025
03ca135
fix tests
R-Palazzo Mar 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdmetrics/single_table/data_augmentation/binary_classifier_precision_efficacy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ def compute_breakdown(
metadata,
prediction_column_name,
minority_class_label,
classifier='xgboost',
classifier='XGBoost',
fixed_recall_value=0.9,
):
"""Compute the score breakdown of the metric."""
Expand Down
1 change: 0 additions & 1 deletion ...s/integration/single_table/data_augmentation/test_binary_classifier_precision_efficacy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ def test_end_to_end(self):
metadata=metadata,
prediction_column_name='gender',
minority_class_label='F',
classifier='XGBoost',
fixed_recall_value=0.8,
)

Expand Down
1 change: 0 additions & 1 deletion tests/integration/single_table/data_augmentation/test_binary_classifier_recall_efficacy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ def test_end_to_end(self):
metadata=metadata,
prediction_column_name='gender',
minority_class_label='F',
classifier='XGBoost',
fixed_precision_value=0.8,
)

Expand Down
8 changes: 2 additions & 6 deletions tests/unit/single_table/data_augmentation/test_binary_classifier_precision_efficacy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,6 @@ def test_compute_breakdown(self, mock_compute_breakdown):
metadata = {}
prediction_column_name = 'prediction_column_name'
minority_class_label = 'minority_class_label'
classifier = 'XGBoost'
fixed_recall_value = 0.8

# Run
BinaryClassifierPrecisionEfficacy.compute_breakdown(
Expand All @@ -43,8 +41,6 @@ def test_compute_breakdown(self, mock_compute_breakdown):
metadata=metadata,
prediction_column_name=prediction_column_name,
minority_class_label=minority_class_label,
classifier=classifier,
fixed_recall_value=fixed_recall_value,
)

# Assert
Expand All @@ -55,8 +51,8 @@ def test_compute_breakdown(self, mock_compute_breakdown):
metadata,
prediction_column_name,
minority_class_label,
classifier,
fixed_recall_value,
'XGBoost',
0.9,
)

@patch('sdmetrics.single_table.data_augmentation.base.BaseDataAugmentationMetric.compute')
Expand Down
8 changes: 2 additions & 6 deletions tests/unit/single_table/data_augmentation/test_binary_classifier_recall_efficacy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,6 @@ def test_compute_breakdown(self, mock_compute_breakdown):
metadata = {}
prediction_column_name = 'prediction_column_name'
minority_class_label = 'minority_class_label'
classifier = 'XGBoost'
fixed_precision_value = 0.8

# Run
BinaryClassifierRecallEfficacy.compute_breakdown(
Expand All @@ -43,8 +41,6 @@ def test_compute_breakdown(self, mock_compute_breakdown):
metadata=metadata,
prediction_column_name=prediction_column_name,
minority_class_label=minority_class_label,
classifier=classifier,
fixed_precision_value=fixed_precision_value,
)

# Assert
Expand All @@ -55,8 +51,8 @@ def test_compute_breakdown(self, mock_compute_breakdown):
metadata,
prediction_column_name,
minority_class_label,
classifier,
fixed_precision_value,
'XGBoost',
0.9,
)

@patch('sdmetrics.single_table.data_augmentation.base.BaseDataAugmentationMetric.compute')
Expand Down
Loading