PolarFire SoC: Initial platform UART support #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axel-h
requested changes
Sep 8, 2020
|
|
||
| static void uart_handle_irq(ps_chardevice_t* d UNUSED) | ||
| { | ||
|
|
There was a problem hiding this comment.
I'd recomment to add a comment that this is empty on purpose. Otherwise one might wonder if soemthing got lost form some failes merge
There was a problem hiding this comment.
Good call, added.
| regs->tx_buffer = c; | ||
| if (c == '\n' && (d->flags & SERIAL_AUTO_CR)) | ||
| { | ||
| uart_putchar(d, '\r'); |
There was a problem hiding this comment.
This writes "\n\r" (LF+CR), but it should actually be "\r\n" (CR+LF ). That's a thing spreading through copy/paste since some time, see also https://github.com/seL4/util_libs/pull/30/commits).
I recommend to rewrite this as
static void busy_wait_fifo_empty_and_tx_char(uart_regs_t* regs, int c)
{
// wait until FIFO empty
while ((regs->line_status & LSR_TX_HOLD_REG_EMPTY_MASK) == 0)
{
// busy loop
}
regs->tx_buffer = c;
}
int uart_putchar(ps_chardevice_t* d, int c)
{
uart_regs_t* regs = uart_get_priv(d);
// turn LF into CR+LF if SERIAL_AUTO_CR is active
if ((c == '\n') && (d->flags & SERIAL_AUTO_CR))
{
busy_wait_fifo_empty_and_tx_char(d,'\r');
}
busy_wait_fifo_empty_and_tx_char(d, c);
return c;
}
There was a problem hiding this comment.
Nice catch, yeah I copied it from another driver.
Jesse-Millwood
force-pushed
the
polarfire-support
branch
from
d71006a
to
aa1199b
Compare
|
looks ok to me now |
|
@ssrg-bamboo |
|
Hello, I'm a bot! I'll bring this PR into Trustworthy Systems and run some tests |
Test results for commit aa1199bSummary
Detailed failure logs
Job: style This is the most I can report on right now, sorry! |
|
Is this simply a failure on my part to run astyle? |
|
Apologize for leaving this PR unhandled for such a long time and thanks for this. |
Jesse-Millwood
force-pushed
the
polarfire-support
branch
from
aa1199b
to
8ded2c7
Compare
No worries! I just pushed the beautified files. |
|
@ssrg-bamboo |
|
Hello, I'm a bot! I'll bring this PR into Trustworthy Systems and run some tests |
|
All the tests we ran have passed! Nice job! |
|
Can you rebase this PR against master? |
Signed-off-by: Jesse Millwood <jesse.millwood@dornerworks.com>
Jesse-Millwood
force-pushed
the
polarfire-support
branch
from
8ded2c7
to
a6a56d6
Compare
|
@ssrg-bamboo |
|
Hello, I'm a bot! I'll bring this PR into Trustworthy Systems and run some tests |
|
All the tests we ran have passed! Nice job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jesse Millwood jesse.millwood@dornerworks.com