Revert "To allow PRs from forks, use pull_request_target" #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 92006f2. This is not what we wanted - it does not run the actions on the code from the PR itself, meaning its previews (for example) are not useful Signed-off-by: Luke Mondy <Luke.Mondy@data61.csiro.au>
|
Preview your changes here |
|
Is there some way in |
lsf37
approved these changes
Sep 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 92006f2.
This is not what we wanted - it does not run the actions on the code
from the PR itself, meaning its previews (for example) are not useful
We still have the issue of GitHub secrets not being shared with forks, which prevents the deploy step 馃
I think the intermediate solution is that PRs should be branches for now, until we work something out.