Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDDLStream custom mappings, arbitrary args, and tuning #61

Merged
merged 22 commits into from
Jan 13, 2023

Conversation

sea-bass
Copy link
Owner

@sea-bass sea-bass commented Jan 12, 2023

This PR modifies the PDDLStream planning pipeline to:

  • Take in any arbitrary functions that return stream mappings/info dictionaries, which will allow users to override not just the planning domain, but those dictionaries. This will fully enable users to make custom domains.
  • Fall back to always using the PDDLStream adaptive planner, and directly pass in keyword args (**kwargs) to simplify interface to planner and allow more flexibility
  • Tuned the search_sample_ratio way down on one of the unit tests to prevent from getting stuck sampling placement poses in a cluttered surface when there was another placement surface wide open some distance away. This was probably the most critical change.
  • Added a raw_collision_polygon attribute to objects to reduce number of times we inflate the raw polygon

I ran the test_pddlstream_manip unit tests locally 100 times in a row to give myself peace of mind, and they consistently seemed to solve in ~60 to 100 seconds (for all 4 tests combined).

I also got rid of some encoding pragma pre-commit check because it was adding stuff I didn't want to files. It's why this PR looks bigger than it actually is.

Closes #47

@sea-bass sea-bass changed the title Pddlstream custom mappings PDDLStream custom mappings, arbitrary args, and tuning Jan 12, 2023
@sea-bass sea-bass marked this pull request as ready for review January 12, 2023 23:21
@sea-bass sea-bass requested a review from AndyZe January 12, 2023 23:22
@sea-bass
Copy link
Owner Author

I'm gonna exercise executive power on this PR because I was sloppy and also fixed CI here, and I really want CI to stop failing.

@AndyZe If you have any feedback, we can handle it in a separate PR.

@sea-bass sea-bass merged commit 3583a5a into main Jan 13, 2023
@sea-bass sea-bass deleted the pddlstream-custom-mappings branch January 13, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to set user-defined mappings for PDDLStream
1 participant