-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PDDLStream custom mappings, arbitrary args, and tuning #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sea-bass
changed the title
Pddlstream custom mappings
PDDLStream custom mappings, arbitrary args, and tuning
Jan 12, 2023
sea-bass
commented
Jan 13, 2023
sea-bass
force-pushed
the
pddlstream-custom-mappings
branch
from
January 13, 2023 19:49
34979cb
to
22f0748
Compare
Merged
sea-bass
force-pushed
the
pddlstream-custom-mappings
branch
from
January 13, 2023 20:30
a82bc2c
to
c377c24
Compare
I'm gonna exercise executive power on this PR because I was sloppy and also fixed CI here, and I really want CI to stop failing. @AndyZe If you have any feedback, we can handle it in a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the PDDLStream planning pipeline to:
**kwargs
) to simplify interface to planner and allow more flexibilitysearch_sample_ratio
way down on one of the unit tests to prevent from getting stuck sampling placement poses in a cluttered surface when there was another placement surface wide open some distance away. This was probably the most critical change.raw_collision_polygon
attribute to objects to reduce number of times we inflate the raw polygonI ran the
test_pddlstream_manip
unit tests locally 100 times in a row to give myself peace of mind, and they consistently seemed to solve in ~60 to 100 seconds (for all 4 tests combined).I also got rid of some encoding pragma pre-commit check because it was adding stuff I didn't want to files. It's why this PR looks bigger than it actually is.
Closes #47