Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor demo_pddl_planner.py to avoid deadlock #66

Merged
merged 2 commits into from
Feb 5, 2023

Conversation

AndyZe
Copy link
Collaborator

@AndyZe AndyZe commented Feb 5, 2023

Use a timer as suggested here:

https://answers.ros.org/question/356686/python-not-able-to-echo-ros2-topics-published-on-thread/

The cause of the deadlock had something to do with rclpy threading intricacies.

@AndyZe AndyZe force-pushed the andyz/get_sub_count_refactor branch 3 times, most recently from 7ff043b to e324ff5 Compare February 5, 2023 06:02
@AndyZe AndyZe changed the title [Draft] Refactor deadlocked get_subscription_count() Refactor demo_pddl_planner.py to avoid deadlock Feb 5, 2023
@AndyZe AndyZe requested a review from sea-bass February 5, 2023 06:03
Copy link
Owner

@sea-bass sea-bass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked for me -- thanks!

pyrobosim_ros/examples/demo_pddl_planner.py Outdated Show resolved Hide resolved
@AndyZe AndyZe force-pushed the andyz/get_sub_count_refactor branch from 503c298 to 1acbf74 Compare February 5, 2023 15:02
@AndyZe AndyZe merged commit d1e2017 into main Feb 5, 2023
@AndyZe AndyZe deleted the andyz/get_sub_count_refactor branch February 5, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants