Skip to content

Tt 6631 implement present override #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 30, 2019
Merged

Tt 6631 implement present override #2

merged 5 commits into from
Dec 30, 2019

Conversation

jmortlock
Copy link
Contributor

WHY

On Rails6 present? and blank? must be implemented differently under the hood and would no longer work.
Updates to test on Rails5/6 only

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 33cf4b4 on TT-6631-implement-present-override into e8f4d7c on master.

@coveralls
Copy link

coveralls commented Dec 30, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling a78a59f on TT-6631-implement-present-override into e8f4d7c on master.

@Steffylicious Steffylicious merged commit 940c93e into master Dec 30, 2019
@Steffylicious Steffylicious deleted the TT-6631-implement-present-override branch December 30, 2019 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@Steffylicious Steffylicious Steffylicious approved these changes

@HellRok HellRok HellRok approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jmortlock @coveralls @Steffylicious @HellRok