Skip to content

fix: Use params type name for DELETE endpoints #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 20, 2024
Merged

fix: Use params type name for DELETE endpoints #116

merged 2 commits into from
Jun 20, 2024

Conversation

razor-x
Copy link
Member

@razor-x razor-x commented Jun 18, 2024 •
edited
Loading

https://stackoverflow.com/questions/299628/is-an-entity-body-allowed-for-an-http-delete-request

If a DELETE request includes an entity body, the body is ignored [...]

@razor-x razor-x marked this pull request as ready for review June 20, 2024 18:55
@razor-x razor-x merged commit 64f672c into main Jun 20, 2024
@razor-x razor-x deleted the params-not-body-for-delete branch June 20, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrii-balitskyi andrii-balitskyi Awaiting requested review from andrii-balitskyi

1 more reviewer

@mastafit mastafit mastafit approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@razor-x @mastafit @seambot