Skip to content

Conversation

razor-x
Copy link
Member

@razor-x razor-x commented Jun 21, 2024

No description provided.

@razor-x razor-x marked this pull request as ready for review June 24, 2024 16:44
Copy link
Member

@phpnode phpnode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, i think this is the nicer default for most consumers. One day we should investigate using EventSource/SSE to avoid polling entirely

@razor-x
Copy link
Member Author

razor-x commented Jun 24, 2024

LGTM, i think this is the nicer default for most consumers. One day we should investigate using EventSource/SSE to avoid polling entirely

@phpnode Nice, fortunately the name is waitForActionAttempt not pollForActionAttempt, so this leaves room in the future to change the underlying implementation (or offer a choice via the object form of the option).

@razor-x
Copy link
Member Author

razor-x commented Jun 24, 2024

TIL about EventSource which I was just thinking about the other day, e.g., "I really wish we had something for realtime push notifications in the browser but lighter weight than full on websockets." Is this that?

@razor-x razor-x merged commit d450e3e into main Jun 24, 2024
@razor-x razor-x deleted the wait-for-action-attempt-by-default branch June 24, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants