This repository was archived by the owner on Nov 15, 2024. It is now read-only.
Use authorization header with client session token #253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
razor-x
changed the title
codetheweb
approved these changes
Jul 27, 2023
seveibar
approved these changes
Jul 27, 2023
seambot
pushed a commit
that referenced
this pull request
Jul 28, 2023
## [8.2.1](seamapi/javascript@v8.2.0...v8.2.1) (2023-07-28) ### Bug Fixes * Use authorization header with client session token ([#253](seamapi/javascript#253)) ([d21b192](seamapi/javascript@d21b192))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think using the custom header may have been a mistake and is partially responsible for the CORS cache issues. Using the
authorizationheader should be more compatible with various protocol layers and give more predictable behavior. We can send both here as a test. We cannot remove the other one yet since CORS behavior depends on the presence of that header.