This repository was archived by the owner on Nov 15, 2024. It is now read-only.
Fix broken "some examples" readme link #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 This PR is included in version 3.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposes a possible fix for the broken "some examples" link at the top of https://github.com/seamapi/javascript/blob/main/README.md.
The paragraph with the examples link appears to have been copied, in commit adbaadb, from the python repo's readme. The python repo has an examples directory, so the link there works. But, the examples for the javascript repo are in the readme under the Usage heading (added by PR seamapi/javascript#4).
My proposed fix is to swap the link to the non-existent examples directory for a list of links to Usage subheading anchors in the readme.