Skip to content

Conversation

xplato
Copy link
Contributor

@xplato xplato commented Sep 7, 2023

Screenshot 2023-09-07 at 11 23 30 AM

@xplato xplato changed the title Add ClimateModeMenu Add ClimateModeMenu Sep 7, 2023
@razor-x
Copy link
Member

razor-x commented Sep 7, 2023

Checking the story, it renders with no value selected (and the options open off screen).
image
image

@xplato
Copy link
Contributor Author

xplato commented Sep 7, 2023

Checking the story, it renders with no value selected (and the options open off screen).

@razor-x I can add a default for the lack of initial value, but I can't seem to replicate the menu position issue (on the deployed story or locally). Do you have any additional context/logs by chance?

@razor-x
Copy link
Member

razor-x commented Sep 7, 2023

Try on Firefox. I think it's the same issue as #424

@xplato
Copy link
Contributor Author

xplato commented Sep 7, 2023

Try on Firefox. I think it's the same issue as #424

I can't replicate on Firefox but I can on Safari. If there's an outstanding issue for it, should that be handled separately?

@razor-x
Copy link
Member

razor-x commented Sep 7, 2023

@xplato Sure. I'm going to mark that one higher priority now.

@xplato xplato merged commit ca15485 into main Sep 7, 2023
@xplato xplato deleted the add-temp-control-menu branch September 7, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants