Skip to content
This repository has been archived by the owner on Sep 9, 2024. It is now read-only.

Fix Decimal serdes #189

Merged
merged 2 commits into from
Nov 2, 2021
Merged

Conversation

qhelix7
Copy link
Contributor

@qhelix7 qhelix7 commented Nov 2, 2021

Use string for serializing and deserializing Decimal type data in order to avoid data corruption caused by casting to float.
See Issue 188.

@seandstewart
Copy link
Owner

Not sure why the test workflow didn't run, I'll have to check the actions configuration, but the change is straightforward enough.

I ran the test suite locally and the doctest for isdecimaltype failed - you'll need to add this new check to __all__.

Otherwise this looks great!

@qhelix7
Copy link
Contributor Author

qhelix7 commented Nov 2, 2021

Not sure why the test workflow didn't run, I'll have to check the actions configuration, but the change is straightforward enough.

I ran the test suite locally and the doctest for isdecimaltype failed - you'll need to add this new check to __all__.

Otherwise this looks great!

Cool. isdecimaltype is now included in __all__.

@seandstewart seandstewart merged commit b5ef7d5 into seandstewart:main Nov 2, 2021
@seandstewart
Copy link
Owner

Thanks for your contribution @qhelix7! I'll make sure to get this out in the next release (probably later today or tomorrow).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants