jQuery TS definitions file doesn't include jqLite version of .on()

[bvaughn]

The jquery.d.ts definition of .on() should include a version without the optional selector parameter since specifying that parameter will result in a jqlite runtime error:

jqLite#on() does not support the `selector` or `eventData` parameters

And TypeScript won't compile a jqLite-compatible version of the .on() method with the current definition:

error TS2345: Argument of type 'string' is not assignable to parameter of type '{ [key: string]: any; }'.

[seanhess]

Hi @bvaughn!

I'm sorry to have confused you. I didn't intend for the definition files to be used from my repository. I'm just demonstrating where to put them.

You should download the latest version from DefinitelyTyped. I bet their jquery.d.ts file already has your fix.

They have TONS of different library definitions. Go check it out!

[seanhess]

Oh, and if it doesn't have your change, please issue a PR to DefinitelyTyped instead of here so everyone can benefit!

[bvaughn]

Haha, well that's funny. Thanks for responding so quickly. :)

Indeed you're right. They've already got the necessary definition. Much appreciated!