Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fn headers() for wasm::multipart #2036

Merged
merged 4 commits into from
Nov 13, 2023

Conversation

bitfl0wer
Copy link
Contributor

Fixes #2035 by stealing two missing functions from the non-wasm part of the library.

@seanmonstar seanmonstar merged commit 6792f69 into seanmonstar:master Nov 13, 2023
31 checks passed
@bitfl0wer
Copy link
Contributor Author

Note: There should likely be tests in place, similar to the ones in async_impl. Maybe I'll open another PR for that soon. Thanks for reviewing/merging!

kodiakhq bot pushed a commit to pdylanross/fatigue that referenced this pull request Dec 19, 2023
Bumps reqwest from 0.11.22 to 0.11.23.

Release notes
Sourced from reqwest's releases.

v0.11.23
What's Changed

Add Proxy::custom_http_auth(val) for setting the raw Proxy-Authorization header when connecting to proxies.
Fix redirect to reject locations that are not http:// or https://.
Fix setting nodelay when TLS is enabled but URL is HTTP.
(wasm) Add ClientBuilder::user_agent(val).
(wasm) add multipart::Form::headers(headers).

New Contributors

@​tnull made their first contribution in seanmonstar/reqwest#1993
@​FirelightFlagboy made their first contribution in seanmonstar/reqwest#2018
@​bitfl0wer made their first contribution in seanmonstar/reqwest#2036
@​tshepang made their first contribution in seanmonstar/reqwest#2048
@​Noah-Kennedy made their first contribution in seanmonstar/reqwest#2053
@​abls made their first contribution in seanmonstar/reqwest#2062
@​lorepozo made their first contribution in seanmonstar/reqwest#2064
@​jan-auer made their first contribution in seanmonstar/reqwest#2068




Changelog
Sourced from reqwest's changelog.

v0.11.23

Add Proxy::custom_http_auth(val) for setting the raw Proxy-Authorization header when connecting to proxies.
Fix redirect to reject locations that are not http:// or https://.
Fix setting nodelay when TLS is enabled but URL is HTTP.
(wasm) Add ClientBuilder::user_agent(val).
(wasm) add multipart::Form::headers(headers).




Commits

4f54ba7 v0.11.23
c65dd7f docs: add cfg notes about http3 builder methods (#2070)
6b901b1 Reject redirects with invalid scheme (#2068)
ea59834 Update README advice regarding OpenSSL (#2064)
1485ce6 fix: set nodelay correctly to handle when a tls feature is enabled but connec...
c09c5e6 proxy: add support for proxy authentication with user-specified header values...
4926d76 typo (#2048)
6792f69 fn headers() for wasm::multipart (#2036)
52190df http3: upgrade dependencies (#2028)
50dbaf3 docs: remove redundant link targets (#2019)
Additional commits viewable in compare view




Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Nutomic pushed a commit to Nutomic/reqwest that referenced this pull request Nov 7, 2024
* Add missing headers() method to wasm::multipart

* Remove duplicate import

* Add headers() to impl PartMetadata
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wasm::multipart: missing fn headers()
2 participants