Skip to content

Should deploy_key also be prefixed with namespace? #2

@kategengler

Description

@kategengler

Great job on this gem!

I started out using this today with ember-cli-deploy 0.5.x and the redis adapter, it seems that by default, the deploy keys are also prefixed. I had to make this change in the gem:

      def deploy_key
-      redis_client.get(current_key).presence || deployment_not_activated!
+      key = redis_client.get(current_key).presence || deployment_not_activated!
+      "#{namespace}:#{key}"
      end

Should those keys be prefixed?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions