Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort questions from asked by most companies to least companies #104

Merged
merged 1 commit into from
Jun 6, 2021
Merged

Conversation

hiromik
Copy link
Contributor

@hiromik hiromik commented May 31, 2021

This allows clicking on "Companies" to sort by questions asked by the most companies to the least companies, slight adjustments made to avoid company's filter to trigger a sort or the tooltip from not being displayed properly

@seanprashad
Copy link
Owner

Thank you so much for spending the time writing this patch @hiromik! I've set a reminder to give it a thorough look later this week when things aren't so busy!!

@seanprashad seanprashad self-requested a review June 4, 2021 20:41
Copy link
Owner

@seanprashad seanprashad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got around to testing this and things are looking great @hiromik!!

thanks-hiromik.mp4

I'll open up a new issue to think of a way to better improve the UX since it's not immediately apparent that this functionality now exists. In any case, thank you once more @hiromik!! 😁

@seanprashad seanprashad merged commit d3198bd into seanprashad:master Jun 6, 2021
@seanprashad
Copy link
Owner

Fixes #99

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants