Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Driver::forLineCoverage() and Driver::forLineAndPathCoverage() are marked as internal #810

Closed
davidrans opened this issue Sep 17, 2020 · 0 comments
Assignees

Comments

@davidrans
Copy link

Q A
php-code-coverage version 9.1.9
PHP version 7.4.5
Driver Xdebug
Xdebug version (if used) v2.9.1
Installation Method Composer
Usage Method PHPUnit
PHPUnit version (if used) 9.3.10

Using the example code in the README, results in some psalm errors about using classes and methods that are marked as @internal.

ERROR: InternalMethod - The method SebastianBergmann\CodeCoverage\Driver\Driver::forLineCoverage is internal to SebastianBergmann but called from Coverage (see https://psalm.dev/175)                                
      $driver = Driver::forLineCoverage($filter);                                                                                                                                                                                                  
                                                                                                                                                                                                                                                   
                                                                                                                                                                                                                                                   
ERROR: InternalClass - SebastianBergmann\CodeCoverage\Driver\Driver is internal to SebastianBergmann but called from Coverage (see https://psalm.dev/174)
      $driver = Driver::forLineCoverage($filter);                                           


ERROR: InternalClass - SebastianBergmann\CodeCoverage\Report\Html\Facade is internal to SebastianBergmann but called from FormatCoverageResults (see https://psalm.dev/174)
         $writer = new \SebastianBergmann\CodeCoverage\Report\Html\Facade();                
                                                                                            
                                                                                            
ERROR: InternalMethod - The method SebastianBergmann\CodeCoverage\Report\Html\Facade::process is internal to SebastianBergmann but called from FormatCoverageResults (see https://psalm.dev/175)
         $writer->process($combinedCoverage, $output);                                      

Here's the example code, from this repo, that I tried to emulate: https://github.com/sebastianbergmann/php-code-coverage/blob/1894b1ae28a543838b200ec337a8748e34b84a5e/README.md#usage

@sebastianbergmann sebastianbergmann changed the title @internal methods/classes are documented in README's example usage Driver::forLineCoverage() and Driver::forLineAndPathCoverage() are marked as internal Sep 18, 2020
@sebastianbergmann sebastianbergmann self-assigned this Sep 18, 2020
smmccabe pushed a commit to smmccabe/php-code-coverage that referenced this issue Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants